Phase 2 of the tenant-marking series. appointments, weekly_schedules and date_overrides kept their environment implicit in a nullable clinic_id, so every query that wanted "this environment's rows" had to rebuild clinic_id IS NULL ? doctor : clinic itself. The two calendar tables also depended on a MariaDB-only generated column, clinic_key = IFNULL(clinic_id, 0), purely to make a unique key work across NULLs. All three now carry the (entity_type, entity_id) pair that service_sections, patient_records and clinic_staff already use, via a shared TenantOwnedTrait. The pair is a deliberate denormalisation of clinic_id/doctor_id: the automatic tenant filter and the tenant-leading indexes both need a real column, and neither can be built on an IF() expression. - Unique keys keep doctor_id alongside the pair. A clinic has several doctors and each has their own schedule, so (entity_type, entity_id) alone would reject the second doctor. - clinic_key is gone from both calendar tables. - appointments gained tenant-leading indexes; EXPLAIN on the panel's list query now picks idx_appointments_tenant_slot. Deliberately unchanged, both with the reason already recorded in the code: active_slot_key stays keyed on doctor + slot, since adding the environment would let one doctor be booked in their own practice and a clinic at the same moment. holidays keeps its nullable clinic_id, where NULL means "every environment" rather than "personal practice" — a meaning the pair cannot carry. The migration adds the columns nullable, backfills, aborts if any row is left without an owner, and only then tightens to NOT NULL. It creates each replacement unique index before dropping the old one, so the tables are never left unprotected — MariaDB commits implicitly on DDL, so ordering is the only safety net. It runs its statements through the connection rather than addSql() because the guard has to sit between the backfill and the NOT NULL change. Columns are NOT NULL with no default on purpose: a construction site that forgets assignTenant() fails at flush instead of silently writing entity_id 0, which the phase 4 filter would then hide from everyone. Verified on the dev database: 0 rows without a tenant, 0 personal bookings mismatched against their doctor, 0 clinic bookings mismatched against their clinic. Tests: 819 passing (813 + 6 new in BookingTenantTest). PHPStan clean on every changed file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
138 lines
5.1 KiB
PHP
138 lines
5.1 KiB
PHP
<?php
|
|
|
|
namespace App\Tests\Appointment;
|
|
|
|
use App\Appointment\Entity\Appointment;
|
|
use App\Appointment\Entity\WeeklySchedule;
|
|
use App\Clinic\Entity\Clinic;
|
|
use App\Doctor\Entity\Doctor;
|
|
use App\Shared\Context\EntityContext;
|
|
use App\Tests\ApiTestCase;
|
|
use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
|
|
|
|
/**
|
|
* Phase 2 of tenant marking: appointments, weekly schedules and date overrides
|
|
* carry their owning environment as the (entity_type, entity_id) pair rather
|
|
* than leaving it implicit in a nullable clinic_id.
|
|
*/
|
|
class BookingTenantTest extends ApiTestCase
|
|
{
|
|
private function makeDoctor(): Doctor
|
|
{
|
|
$doctor = new Doctor($this->createUser(['ROLE_DOCTOR']), 'دکتر تست محیط');
|
|
$this->em->persist($doctor);
|
|
$this->em->flush();
|
|
|
|
return $doctor;
|
|
}
|
|
|
|
private function makeClinic(): Clinic
|
|
{
|
|
$clinic = new Clinic($this->createUser(['ROLE_CLINIC']));
|
|
$clinic->setName('کلینیک تست محیط');
|
|
$this->em->persist($clinic);
|
|
$this->em->flush();
|
|
|
|
return $clinic;
|
|
}
|
|
|
|
private function uniqueSlot(): int
|
|
{
|
|
return strtotime('+90 days') + random_int(0, 500_000) * 7;
|
|
}
|
|
|
|
public function testPersonalBookingIsOwnedByTheDoctor(): void
|
|
{
|
|
$doctor = $this->makeDoctor();
|
|
$start = $this->uniqueSlot();
|
|
|
|
$appointment = $this->newAppointment($doctor, $this->createUser(), $start, $start + 900);
|
|
$this->em->persist($appointment);
|
|
$this->em->flush();
|
|
|
|
self::assertSame('doctor', $appointment->getEntityType());
|
|
self::assertSame($doctor->getId(), $appointment->getEntityId());
|
|
}
|
|
|
|
public function testClinicBookingIsOwnedByTheClinic(): void
|
|
{
|
|
$doctor = $this->makeDoctor();
|
|
$clinic = $this->makeClinic();
|
|
$clinic->getDoctors()->add($doctor);
|
|
$this->em->flush();
|
|
|
|
$start = $this->uniqueSlot();
|
|
$appointment = $this->newAppointment($doctor, $this->createUser(), $start, $start + 900, $clinic);
|
|
$this->em->persist($appointment);
|
|
$this->em->flush();
|
|
|
|
self::assertSame('clinic', $appointment->getEntityType());
|
|
self::assertSame($clinic->getId(), $appointment->getEntityId());
|
|
}
|
|
|
|
/** یک پزشک در دو محیط = دو مالک متفاوت برای دو نوبت. */
|
|
public function testSameDoctorGetsDifferentOwnersInDifferentEnvironments(): void
|
|
{
|
|
$doctor = $this->makeDoctor();
|
|
$clinic = $this->makeClinic();
|
|
$clinic->getDoctors()->add($doctor);
|
|
$this->em->flush();
|
|
|
|
$personal = $this->newAppointment($doctor, $this->createUser(), $this->uniqueSlot(), $this->uniqueSlot() + 900);
|
|
$inClinic = $this->newAppointment($doctor, $this->createUser(), $this->uniqueSlot(), $this->uniqueSlot() + 900, $clinic);
|
|
$this->em->persist($personal);
|
|
$this->em->persist($inClinic);
|
|
$this->em->flush();
|
|
|
|
self::assertSame(['doctor', $doctor->getId()], [$personal->getEntityType(), $personal->getEntityId()]);
|
|
self::assertSame(['clinic', $clinic->getId()], [$inClinic->getEntityType(), $inClinic->getEntityId()]);
|
|
}
|
|
|
|
/** ❌ محیط حلنشده هرگز ذخیره نمیشود — نه با شناسهٔ صفر، نه بیصدا. */
|
|
public function testAssigningAnUnresolvedContextIsRejected(): void
|
|
{
|
|
$doctor = $this->makeDoctor();
|
|
$start = $this->uniqueSlot();
|
|
$appointment = new Appointment($doctor, $this->createUser(), $start, $start + 900);
|
|
|
|
$this->expectException(\InvalidArgumentException::class);
|
|
$appointment->assignTenant(EntityContext::unknown());
|
|
}
|
|
|
|
/**
|
|
* ⚠️ حالت مرزی: دو پزشکِ متفاوت در یک کلینیک، هر کدام برنامهٔ هفتگی خودشان —
|
|
* کلید یکتا باید doctor_id را هم داشته باشد وگرنه پزشک دوم رد میشود.
|
|
*/
|
|
public function testTwoDoctorsInOneClinicEachKeepTheirOwnSchedule(): void
|
|
{
|
|
$clinic = $this->makeClinic();
|
|
$doctorA = $this->makeDoctor();
|
|
$doctorB = $this->makeDoctor();
|
|
$clinic->getDoctors()->add($doctorA);
|
|
$clinic->getDoctors()->add($doctorB);
|
|
$this->em->flush();
|
|
|
|
$this->em->persist($this->newWeeklySchedule($doctorA, [], $clinic));
|
|
$this->em->persist($this->newWeeklySchedule($doctorB, [], $clinic));
|
|
$this->em->flush();
|
|
|
|
$rows = $this->em->getRepository(WeeklySchedule::class)
|
|
->findBy(['entityType' => 'clinic', 'entityId' => $clinic->getId()]);
|
|
|
|
self::assertCount(2, $rows);
|
|
}
|
|
|
|
/** همان پزشک، همان محیط، دو برنامه — هنوز غیرممکن است. */
|
|
public function testOneSchedulePerEnvironmentPerDoctorIsStillEnforced(): void
|
|
{
|
|
$doctor = $this->makeDoctor();
|
|
|
|
$this->em->persist($this->newWeeklySchedule($doctor, []));
|
|
$this->em->flush();
|
|
|
|
$this->em->persist($this->newWeeklySchedule($doctor, []));
|
|
$this->expectException(UniqueConstraintViolationException::class);
|
|
$this->em->flush();
|
|
}
|
|
}
|