Files
clinicpro/tests/Secretary/SecretaryMultiClinicScopeTest.php
T
hamedandClaude Opus 5 2e0888e0ef refactor(tenant): give every table one spelling of the tenant pair
Phase 3 of the tenant-marking series. The same concept was written four ways,
and the Doctrine filter arriving in phase 4 keys on the field name — so the
tables using a different spelling would have been skipped silently, which is
exactly the leak this work exists to prevent.

- discount_rules: owner_type/owner_id renamed to entity_type/entity_id. Pure
  rename, no data moves.
- doctor_secretaries: owner_type plus a nullable clinic_id replaced by the
  shared pair. The environment now comes from the clinic argument alone, so the
  inconsistent combination (owner_type='clinic', clinic_id=NULL) can no longer
  be constructed, and the redundant constructor parameter is gone.
- user_active_context: added db_type, so resolving an environment is one lookup
  instead of "try clinics, then try doctors". Filled from the type already
  present in available_contexts.
- entity_type is VARCHAR(10) in all twenty tenant tables; four of them were 20.

Behaviour change, the only one in this series: the doctor_secretaries unique key
went from (doctor_id, secretary_id, owner_type) to (doctor_id, secretary_id,
entity_type, entity_id). With clinic_id outside the key, one secretary could not
be assigned to the same doctor in two clinics — the second row collided on
owner_type='clinic'. The duplicate check in SecretaryController had the same
blind spot and would have rejected the request before the database saw it; both
are fixed together.

Correcting an assumption from the phase-3 plan: mobile_verification_otp.entity_type
really is a tenant pair. NotificationMobileController validates the target against
['doctor','clinic'] and stores that entity's id, so the column was normalised with
the rest rather than treated as unrelated.

TenantOwnedTrait gained assignTenantPair() for callers that resolved the pair as
scalars and hold no entity — building an EntityContext from scalars would produce
one where isClinic() is true but ->clinic is null, breaking consumers silently.

tests/ApiTestCase::createUser now retries on a duplicate mobile. db_test is never
reset and already holds ~38k users, so the 9-digit random draw collided often
enough to fail unrelated tests a few percent of runs.

Tests: 830 passing. PHPStan reports no new errors on the changed files.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-28 11:56:57 +03:30

108 lines
4.4 KiB
PHP

<?php
namespace App\Tests\Secretary;
use App\Clinic\Entity\Clinic;
use App\Doctor\Entity\Doctor;
use App\Secretary\Entity\DoctorSecretary;
use App\Secretary\Repository\DoctorSecretaryRepository;
use App\Tests\ApiTestCase;
use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
/**
* The scope key used to be (doctor_id, secretary_id, owner_type), which left
* clinic_id out. A secretary assigned to one doctor in two clinics collided on
* the second row because both said owner_type = 'clinic'. Phase 3 folded the
* tenant pair into the key, so the environment is part of the identity.
*/
class SecretaryMultiClinicScopeTest extends ApiTestCase
{
private function makeDoctor(): Doctor
{
$doctor = new Doctor($this->createUser(['ROLE_DOCTOR']), 'دکتر چند-کلینیک');
$this->em->persist($doctor);
$this->em->flush();
return $doctor;
}
private function makeClinic(Doctor $doctor): Clinic
{
$clinic = new Clinic($this->createUser(['ROLE_CLINIC']));
$clinic->setName('کلینیک تست منشی');
$clinic->getDoctors()->add($doctor);
$this->em->persist($clinic);
$this->em->flush();
return $clinic;
}
public function testSameSecretaryCanServeSameDoctorInTwoDifferentClinics(): void
{
$doctor = $this->makeDoctor();
$clinicA = $this->makeClinic($doctor);
$clinicB = $this->makeClinic($doctor);
$secretary = $this->createUser(['ROLE_SECRETARY']);
$this->em->persist(new DoctorSecretary($doctor, $secretary, $clinicA));
$this->em->persist(new DoctorSecretary($doctor, $secretary, $clinicB));
$this->em->flush();
/** @var DoctorSecretaryRepository $repo */
$repo = $this->em->getRepository(DoctorSecretary::class);
$inA = $repo->findActiveClinicRow($secretary, $clinicA, $doctor);
$inB = $repo->findActiveClinicRow($secretary, $clinicB, $doctor);
self::assertNotNull($inA, 'رابطهٔ کلینیک اول باید پیدا شود');
self::assertNotNull($inB, 'رابطهٔ کلینیک دوم باید پیدا شود');
self::assertNotSame($inA->getId(), $inB->getId(), 'دو ردیف مستقل، نه یک ردیف مشترک');
self::assertSame($clinicA->getId(), $inA->getEntityId());
self::assertSame($clinicB->getId(), $inB->getEntityId());
}
/** همان پزشک، همان منشی، همان کلینیک — هنوز تکراری است. */
public function testDuplicateAssignmentInTheSameClinicIsStillRejected(): void
{
$doctor = $this->makeDoctor();
$clinic = $this->makeClinic($doctor);
$secretary = $this->createUser(['ROLE_SECRETARY']);
$this->em->persist(new DoctorSecretary($doctor, $secretary, $clinic));
$this->em->flush();
$this->em->persist(new DoctorSecretary($doctor, $secretary, $clinic));
$this->expectException(UniqueConstraintViolationException::class);
$this->em->flush();
}
/** محیط شخصی و محیط کلینیک دو مالک متفاوت‌اند، پس هر دو کنار هم می‌نشینند. */
public function testPersonalAndClinicAssignmentsCoexist(): void
{
$doctor = $this->makeDoctor();
$clinic = $this->makeClinic($doctor);
$secretary = $this->createUser(['ROLE_SECRETARY']);
$personal = new DoctorSecretary($doctor, $secretary);
$inClinic = new DoctorSecretary($doctor, $secretary, $clinic);
$this->em->persist($personal);
$this->em->persist($inClinic);
$this->em->flush();
self::assertSame(['doctor', $doctor->getId()], [$personal->getEntityType(), $personal->getEntityId()]);
self::assertSame(['clinic', $clinic->getId()], [$inClinic->getEntityType(), $inClinic->getEntityId()]);
}
/** بدون کلینیک، محیط همان مطب شخصی است — ترکیب ناسازگار اصلاً بیان‌شدنی نیست. */
public function testAssignmentWithoutAClinicBelongsToThePersonalPractice(): void
{
$doctor = $this->makeDoctor();
$secretary = $this->createUser(['ROLE_SECRETARY']);
$relation = new DoctorSecretary($doctor, $secretary, null);
self::assertSame('doctor', $relation->getEntityType());
self::assertSame($doctor->getId(), $relation->getEntityId());
}
}