hamedandClaude Opus 4.8
61ac775175
- M10 GET /settlement: was unbounded; add page/limit + countByUser + data.meta.
- M11 GET /admin/comments/pending: paginate findPending + countPending.
- M12 GET /comments/{doctor}: paginate the fetch-joined roots query via
Paginator(fetchJoinCollection) + countApprovedRootsByDoctor.
All keep the existing { data: { data: [...] } } envelope and add data.meta
(backward compatible). Default limit 50 / max 100.
Regressions: SettlementListPaginationTest, CommentPaginationTest (both fail
without the limits). Also de-flaked SendCodeMobileRateLimitTest (randomised the
IP block so the persistent per-IP limiter buckets don't accumulate across runs).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
51 lines
1.8 KiB
PHP
51 lines
1.8 KiB
PHP
<?php
|
|
|
|
namespace App\Tests\Rating;
|
|
|
|
use App\Doctor\Entity\Doctor;
|
|
use App\Rating\Entity\Comment;
|
|
use App\Tests\ApiTestCase;
|
|
|
|
/**
|
|
* Both the public per-doctor comment list and the admin pending-comment list
|
|
* must page rather than return every row.
|
|
*/
|
|
class CommentPaginationTest extends ApiTestCase
|
|
{
|
|
public function testPublicListPaginates(): void
|
|
{
|
|
$doctor = new Doctor($this->createUser(['ROLE_DOCTOR']), 'دکتر');
|
|
$this->em->persist($doctor);
|
|
for ($i = 0; $i < 7; $i++) {
|
|
$this->em->persist((new Comment($this->createUser(), $doctor, "نظر $i"))->approve());
|
|
}
|
|
$this->em->flush();
|
|
|
|
$this->client->request('GET', '/api/v1/comments/' . $doctor->getUuid() . '?limit=5');
|
|
$body = json_decode($this->client->getResponse()->getContent(), true);
|
|
|
|
$this->assertSame(200, $this->responseCode());
|
|
$this->assertCount(5, $body['data']['data']);
|
|
$this->assertSame(7, $body['data']['meta']['totalRecords']);
|
|
}
|
|
|
|
public function testAdminPendingListPaginates(): void
|
|
{
|
|
$doctor = new Doctor($this->createUser(['ROLE_DOCTOR']), 'دکتر');
|
|
$this->em->persist($doctor);
|
|
$admin = $this->createUser(['ROLE_ADMIN']);
|
|
for ($i = 0; $i < 7; $i++) {
|
|
// not approved → pending
|
|
$this->em->persist(new Comment($this->createUser(), $doctor, "در انتظار $i"));
|
|
}
|
|
$this->em->flush();
|
|
|
|
$body = $this->authJson('GET', '/api/v1/admin/comments/pending?limit=5', $admin);
|
|
|
|
$this->assertSame(200, $this->responseCode());
|
|
$this->assertCount(5, $body['data']['data']);
|
|
// pending is global (not per-doctor); db_test may hold others → at least 7
|
|
$this->assertGreaterThanOrEqual(7, $body['data']['meta']['totalRecords']);
|
|
}
|
|
}
|