Files
clinicpro/assets/admin/components/layout/Sidebar.test.tsx
T
hamedandClaude Opus 4.8 54c8b008bf fix(secretary): settings menu structure, clinic timeline access, patient delete gate
Three reported secretary-access bugs.

1) Settings menu structure. Phase B flat-listed staff/discounts/sms/tags/
   appointment_settings/clinic_doctors in the secretary's main sidebar. Mirror
   the doctor/clinic layout instead: only inventory + services stay in the main
   «مدیریت» nav; the rest live under a single «تنظیمات» entry
   (→ /admin/account-settings). Made both settings navs permission-aware for
   secretaries: SETTINGS_MENU (menuForRole now takes `can`) and
   PurchaseSubscriptionSidebar filter by a per-item `perm`/`alwaysOpen` instead
   of role only, so a secretary sees exactly their permitted settings pages and
   owner-only items (subscription, secretary-management) stay hidden.

2) Clinic secretary appointment timeline. AppointmentsPage treated a
   clinic-scoped secretary as a single-doctor profile: the doctor list was
   fetched/shown only for isClinic/isAdmin, so no doctor tabs, timeline, or
   booking. Now a clinic-scoped secretary is multi-doctor: fetches the doctor
   list, shows tabs, auto-selects the first doctor. The list comes from a new
   authenticated endpoint GET /api/v1/my/clinic-doctors returning only the
   secretary's ASSIGNED doctors — /clinic/doctor-list is on the public (no-JWT)
   firewall and cannot scope by user, so it would have leaked unbookable doctors.

3) Patient record delete. The `patients.delete` toggle was dead: every record
   delete (note/medical-record/attachment/call/message) was gated as
   `patients.update`. Mapped them to `patients.delete` so the toggle is honored
   and delete is controllable separately from edit.

New SecretaryAccessChecker::assignedClinicDoctorIds. Tests: doctor-list scoping,
patients.delete separation (denied/allowed). docs/api secretary.md +
appointment.md updated. Backend 286 + frontend 25 pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-23 18:01:32 +03:30

145 lines
6.4 KiB
TypeScript

import { fireEvent, screen } from "@testing-library/react";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { renderWithProviders } from "../../test/utils";
vi.mock("../../hooks/useSubscription", () => ({
useSubscription: () => ({ hasFeature: () => true }),
}));
import { useAuthStore } from "../../stores/authStore";
import Sidebar from "./Sidebar";
describe("Sidebar — expandable نوبت‌ها menu", () => {
beforeEach(() => {
useAuthStore.setState({
primaryRole: "admin",
dbUuid: "c1",
userName: "ادمین",
availableContexts: [],
context: null,
} as any);
});
it("keeps نوبت‌ها always expanded regardless of route and click", () => {
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
// منوی والد به شکل دکمه
const parent = screen.getByRole("button", { name: /نوبت‌ها/ });
expect(parent).toBeInTheDocument();
// حتی خارج از مسیر نوبت‌ها، زیرمنوها همیشه دیده می‌شوند
expect(screen.getByText("نوبت ها")).toBeInTheDocument();
expect(screen.getByText("افزودن نوبت")).toBeInTheDocument();
// کلیک روی والد آن را جمع نمی‌کند
fireEvent.click(parent);
expect(screen.getByText("نوبت ها")).toBeInTheDocument();
expect(screen.getByText("افزودن نوبت")).toBeInTheDocument();
});
it("auto-expands when a child route is active", () => {
renderWithProviders(<Sidebar />, { route: "/admin/appointments/new" });
// چون «افزودن نوبت» فعال است، منو باید خودکار باز باشد
expect(screen.getByText("افزودن نوبت")).toBeInTheDocument();
expect(screen.getByText("نوبت ها")).toBeInTheDocument();
});
});
describe("Sidebar — خدمات در منوی اصلی (نه تنظیمات)", () => {
it("shows خدمات in the clinic main menu linking to /admin/clinic-services", () => {
useAuthStore.setState({
primaryRole: "clinic",
dbUuid: "c1",
userName: "کلینیک",
availableContexts: [],
context: null,
} as any);
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
expect(screen.getByText("سرویس ها").closest("a")).toHaveAttribute(
"href",
"/admin/clinic-services",
);
});
it("shows خدمات in the doctor main menu linking to /admin/clinic-services", () => {
useAuthStore.setState({
primaryRole: "doctor",
dbUuid: null,
userName: "پزشک",
availableContexts: [],
context: null,
} as any);
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
expect(screen.getByText("سرویس ها").closest("a")).toHaveAttribute(
"href",
"/admin/clinic-services",
);
});
});
describe("Sidebar — گِیت منوی منشی بر اساس مجوز", () => {
const setSecretary = (resources: Record<string, Record<string, boolean>>) =>
useAuthStore.setState({
primaryRole: "secretary",
dbUuid: "c1",
userName: "منشی",
availableContexts: [],
context: { scope: "clinic", permissions: { resources } },
} as any);
it("منشیِ بدون مجوز، سرویس‌ها/انبار/تگ‌ها را نمی‌بیند", () => {
setSecretary({ appointments: { view: true } });
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
expect(screen.queryByText("سرویس ها")).not.toBeInTheDocument();
expect(screen.queryByText("انبارداری")).not.toBeInTheDocument();
expect(screen.queryByText("تگ‌ها")).not.toBeInTheDocument();
});
it("با مجوز services.view، آیتم «سرویس ها» به /admin/clinic-services می‌رود", () => {
setSecretary({ services: { view: true } });
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
expect(screen.getByText("سرویس ها").closest("a")).toHaveAttribute(
"href",
"/admin/clinic-services",
);
});
it("انبارداری با مجوز inventory.view در سایدبار اصلی می‌آید", () => {
setSecretary({ inventory: { view: true } });
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
expect(screen.getByText("انبارداری").closest("a")).toHaveAttribute(
"href",
"/admin/inventory",
);
});
it("آیتم «تنظیمات» همیشه برای منشی نمایش داده می‌شود", () => {
setSecretary({ appointments: { view: true } });
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
// «تنظیمات» هم عنوان بخش است هم آیتم؛ فقط لینکِ آیتم را می‌سنجیم.
expect(screen.getByRole("link", { name: "تنظیمات" })).toHaveAttribute(
"href",
"/admin/account-settings",
);
});
it("منابعِ زیرمجموعهٔ تنظیمات (staff/discounts/sms/tags/appointment/clinic_doctors) در سایدبار اصلی نمی‌آیند", () => {
// حتی با همهٔ مجوزها، این‌ها باید فقط داخل صفحهٔ تنظیمات باشند نه nav اصلی.
setSecretary({
staff: { view: true },
discounts: { view: true },
sms: { view: true },
tags: { view: true },
appointment_settings: { view: true },
clinic_doctors: { view: true },
});
renderWithProviders(<Sidebar />, { route: "/admin/dashboard" });
expect(screen.queryByText("پرسنل")).not.toBeInTheDocument();
expect(screen.queryByText("تخفیف‌ها")).not.toBeInTheDocument();
expect(screen.queryByText("پیامک‌ها")).not.toBeInTheDocument();
expect(screen.queryByText("تگ‌ها")).not.toBeInTheDocument();
expect(screen.queryByText("تنظیمات نوبت‌دهی")).not.toBeInTheDocument();
expect(screen.queryByText("پزشکان کلینیک")).not.toBeInTheDocument();
});
});