hamedandClaude Opus 5
aa6ea45a57
Strategies (task 06 debt, task 12 dependency) - ResourcePicker orders candidates; it deliberately does not choose. Only the engine knows which resource actually fits this slot and which was already taken by another role, and a strategy that picked would have to duplicate both checks - Four implementations behind a tagged iterator: first_available (name order, the previous behaviour and still the default because it is predictable), least_gap, least_loaded, same_as_previous - least_gap and least_loaded are deliberate opposites and both are correct; choosing between them is a business decision, so it lives in settings - same_as_previous lifts a course's preferred resource to the front and keeps everyone else behind it. A preference, not a filter: forcing the same operator would make the patient wait two weeks, which is worse than a different operator - Availability accepts course_uuid to supply that preference, closing the dependency task 12 recorded against task 06 - An unknown strategy falls back at search time but is rejected at save time. Stale settings must not stop bookings; a user typing a wrong value must not believe it took effect Test suite flake createUser() retries on a mobile-number collision — db_test is never reset and holds tens of thousands of users, so the random draw does collide. The failed INSERT closes the EntityManager, and the retry asked the container for it again, which hands back the *same closed instance*. So the retry threw, and every later test in that process inherited a dead manager. That is the intermittent "EntityManager is closed" on an unrelated, always-different test that made roughly half of full runs red and never reproduced in a subset. Resetting the registry gives a live manager back. UserCollisionRetryTest pins it by closing the manager on purpose. Two consecutive full runs are green: 1334 tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
54 lines
2.4 KiB
PHP
54 lines
2.4 KiB
PHP
<?php
|
|
|
|
namespace App\Tests\Shared;
|
|
|
|
use App\Auth\Entity\User;
|
|
use App\Tests\ApiTestCase;
|
|
use Doctrine\ORM\EntityManagerInterface;
|
|
|
|
/**
|
|
* ساختِ کاربر آزمون پس از تصادم شمارهٔ موبایل باید سالم ادامه بدهد.
|
|
*
|
|
* `db_test` هرگز ریست نمیشود و دهها هزار کاربر دارد، پس قرعهٔ تصادفی گاهی تکراری
|
|
* میشود. INSERT شکستخورده EntityManager را **میبندد**، و گرفتن دوبارهٔ آن از
|
|
* کانتینر همان نمونهٔ بسته را برمیگرداند — تا وقتی رجیستری ریست نشود.
|
|
*
|
|
* تا پیش از این اصلاح، همین باعث میشد اجرای کامل بهصورت متناوب روی یک تستِ
|
|
* **بیربط** با «EntityManager is closed» بیفتد.
|
|
*/
|
|
class UserCollisionRetryTest extends ApiTestCase
|
|
{
|
|
public function testAClosedManagerIsReplacedNotReused(): void
|
|
{
|
|
$before = $this->em;
|
|
|
|
// بستن عمدی: درج تکراری روی کلید یکتای موبایل.
|
|
$existing = $this->createUser(['ROLE_USER']);
|
|
|
|
try {
|
|
$clash = new User($existing->getMobileNumber());
|
|
$clash->setRoles(['ROLE_USER']);
|
|
$clash->setStatus(1);
|
|
$this->em->persist($clash);
|
|
$this->em->flush();
|
|
|
|
self::fail('درج تکراری باید شکست بخورد');
|
|
} catch (\Throwable) {
|
|
// همان چیزی که در قرعهٔ تصادفی اتفاق میافتد.
|
|
}
|
|
|
|
self::assertFalse($before->isOpen(), 'INSERT شکستخورده باید EntityManager را ببندد');
|
|
|
|
static::getContainer()->get('doctrine')->resetManager();
|
|
$this->em = static::getContainer()->get(EntityManagerInterface::class);
|
|
|
|
// کانتینر یک proxy برمیگرداند، پس هویت شیء عوض نمیشود؛ چیزی که اهمیت دارد
|
|
// این است که پشتِ همان proxy یک EntityManager **باز** نشسته باشد.
|
|
self::assertTrue($this->em->isOpen(), 'پس از ریست رجیستری باید مدیر باز باشد');
|
|
|
|
// و کار عادی باید ادامه پیدا کند.
|
|
$fresh = $this->createUser(['ROLE_USER']);
|
|
self::assertNotNull($fresh->getId());
|
|
}
|
|
}
|