perf(appointment): batch-fetch pending payments in expiry loop (fix N+1)

AppointmentExpiryService ran one findPendingByAppointment query per expiring
booking. Add PaymentRepository::findPendingByAppointments (one IN query keyed
by appointment id) and use it. Test covers expiry + payment cancellation for
several appointments at once.

src/Appointment/Service/AppointmentExpiryService.php

@@ -29,12 +29,16 @@ class AppointmentExpiryService
             $expired[$appointment->getUuid()] = $appointment;
         }
 
+        // Fetch all pending payments for the expiring appointments in one query
+        // instead of one lookup per appointment (was N+1 in this scheduler loop).
+        $pendingByAppointment = $this->paymentRepo->findPendingByAppointments(array_values($expired));
+
         $count = 0;
         foreach ($expired as $appointment) {
             $appointment->transitionTo(Appointment::STATUS_EXPIRED);
             $this->appointmentRepo->save($appointment, false);
 
-            $payment = $this->paymentRepo->findPendingByAppointment($appointment);
+            $payment = $pendingByAppointment[$appointment->getId()] ?? null;
             if ($payment !== null) {
                 $payment->setStatus(Payment::STATUS_CANCELED);
                 $this->paymentRepo->save($payment, false);

src/Payment/Repository/PaymentRepository.php

@@ -62,6 +62,36 @@ class PaymentRepository extends ServiceEntityRepository
         ]);
     }
 
+    /**
+     * Batch variant of findPendingByAppointment: all pending payments for the
+     * given appointments in ONE query, keyed by appointment id. Avoids the N+1
+     * in AppointmentExpiryService when many bookings expire at once.
+     *
+     * @param Appointment[] $appointments
+     * @return array<int, Payment> appointment id => pending Payment
+     */
+    public function findPendingByAppointments(array $appointments): array
+    {
+        if ($appointments === []) {
+            return [];
+        }
+
+        $payments = $this->createQueryBuilder('p')
+            ->andWhere('p.appointment IN (:appointments)')
+            ->andWhere('p.status = :status')
+            ->setParameter('appointments', $appointments)
+            ->setParameter('status', Payment::STATUS_PENDING)
+            ->getQuery()
+            ->getResult();
+
+        $byAppointment = [];
+        foreach ($payments as $payment) {
+            $byAppointment[$payment->getAppointment()->getId()] = $payment;
+        }
+
+        return $byAppointment;
+    }
+
     public function save(Payment $entity, bool $flush = true): void
     {
         $this->getEntityManager()->persist($entity);