hamed/clinicpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(billing,settlement): paginate claims and wallet transactions (H9, H10)

Browse Source 
GET /billing/claims loaded every tenant claim with no limit. Add
findByTenant(page, limit) + countByTenant (shared query builder), default
limit 50 / max 100, and expose totals as data.meta — kept inside the existing
{ data: { data: [...] } } envelope so current clients are unaffected.

GET /wallet/transactions was already bounded (findByUser defaulted to limit 50)
but page-less; add page/offset + countByUser + the same additive meta.

Regression: tests/Billing/ClaimsListPaginationTest,
tests/Settlement/WalletTransactionsPaginationTest.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
hamed
2026-06-28 19:42:04 +03:30
co-authored by Claude Opus 4.8
parent 42d934abc2
commit d8f7db0ada
9 changed files with 161 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Settlement/WalletTransactionsPaginationTest.php
+31
View File
@@ -0,0 +1,31 @@
<?php
namespace App\Tests\Settlement;
use App\Settlement\Entity\WalletTransaction;
use App\Tests\ApiTestCase;
/**
* GET /wallet/transactions must page rather than return an unbounded list, and
* expose totals in meta without breaking the existing data.data envelope.
*/
class WalletTransactionsPaginationTest extends ApiTestCase
{
public function testPaginatesAndReportsTotals(): void
{
$user = $this->createUser();
for ($i = 0; $i < 7; $i++) {
$this->em->persist(new WalletTransaction($user, 1000, 'credit', 1000));
}
$this->em->flush();
$body = $this->authJson('GET', '/api/v1/wallet/transactions?limit=5', $user);
$this->assertSame(200, $this->responseCode());
$this->assertCount(5, $body['data']['data']);
$this->assertSame(7, $body['data']['meta']['totalRecords']);
$this->assertSame(2, $body['data']['meta']['totalPages']);
$page2 = $this->authJson('GET', '/api/v1/wallet/transactions?limit=5&page=2', $user);
$this->assertCount(2, $page2['data']['data']);
}
}