hamed/clinicpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(migrations): ensure safe migration steps for doctor_expertise and doctor_cities, drop legacy tables conditionally

Browse Source
This commit is contained in:
hamed
2026-06-28 09:32:27 +03:30
parent e966e11807
commit 90a908c503
3 changed files with 83 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
migrations/Version20260610140853.php
+56 -14
View File
@@ -23,23 +23,65 @@ final class Version20260610140853 extends AbstractMigration
public function up(Schema $schema): void
{
// Remove rows in doctor_expertise whose service_id doesn't exist in doctor_services
$this->addSql('DELETE FROM doctor_expertise WHERE service_id NOT IN (SELECT id FROM doctor_services)');
// NOTE: All of this work is also performed by Version20260610103401
// (same day, earlier timestamp). On a fresh database that migration runs
// first and leaves doctor_expertise / doctor_cities already converted and
// the categories table already dropped, so re-running these statements
// verbatim fails (errno 121: duplicate constraint FK_ED88BE60ED5CA9E6).
//
// Existing databases, however, may have applied THIS migration without
// 103401 having done the conversion. So instead of deleting this file we
// make every step idempotent: each action is guarded against the state
// 103401 leaves behind, so the migration is a safe no-op on a fresh DB
// and still finishes the conversion on an older DB.
// Add FK constraint to doctor_expertise
$this->addSql('ALTER TABLE doctor_expertise ADD CONSTRAINT FK_ED88BE60ED5CA9E6 FOREIGN KEY (service_id) REFERENCES doctor_services (id)');
$this->addSql('CREATE INDEX IDX_ED88BE60ED5CA9E6 ON doctor_expertise (service_id)');
// doctor_expertise: ensure category_id → service_id + FK exist (only if not already done by 103401)
$this->addSql(<<<'SQL'
DROP PROCEDURE IF EXISTS __mig_140853
SQL);
$this->addSql(<<<'SQL'
CREATE PROCEDURE __mig_140853()
BEGIN
DECLARE db VARCHAR(64);
SET db = DATABASE();
// doctor_cities: category_id → city_id with FK to cities
$this->addSql('DELETE FROM doctor_cities WHERE category_id NOT IN (SELECT id FROM cities)');
$this->addSql('ALTER TABLE doctor_cities DROP FOREIGN KEY `FK_7DC181E612469DE2`');
$this->addSql('DROP INDEX IDX_7DC181E612469DE2 ON doctor_cities');
$this->addSql('ALTER TABLE doctor_cities CHANGE category_id city_id INT NOT NULL, DROP PRIMARY KEY, ADD PRIMARY KEY (doctor_id, city_id)');
$this->addSql('ALTER TABLE doctor_cities ADD CONSTRAINT FK_7DC181E68BAC62AF FOREIGN KEY (city_id) REFERENCES cities (id)');
$this->addSql('CREATE INDEX IDX_7DC181E68BAC62AF ON doctor_cities (city_id)');
-- doctor_expertise.service_id FK
IF NOT EXISTS (
SELECT 1 FROM information_schema.TABLE_CONSTRAINTS
WHERE CONSTRAINT_SCHEMA = db AND TABLE_NAME = 'doctor_expertise'
AND CONSTRAINT_NAME = 'FK_ED88BE60ED5CA9E6'
) THEN
DELETE FROM doctor_expertise WHERE service_id NOT IN (SELECT id FROM doctor_services);
ALTER TABLE doctor_expertise
ADD CONSTRAINT FK_ED88BE60ED5CA9E6 FOREIGN KEY (service_id) REFERENCES doctor_services (id);
CREATE INDEX IDX_ED88BE60ED5CA9E6 ON doctor_expertise (service_id);
END IF;
// Drop the now-unused categories table
$this->addSql('DROP TABLE categories');
-- doctor_cities: category_id → city_id with FK to cities
IF EXISTS (
SELECT 1 FROM information_schema.COLUMNS
WHERE TABLE_SCHEMA = db AND TABLE_NAME = 'doctor_cities'
AND COLUMN_NAME = 'category_id'
) THEN
DELETE FROM doctor_cities WHERE category_id NOT IN (SELECT id FROM cities);
ALTER TABLE doctor_cities DROP FOREIGN KEY `FK_7DC181E612469DE2`;
DROP INDEX IDX_7DC181E612469DE2 ON doctor_cities;
ALTER TABLE doctor_cities CHANGE category_id city_id INT NOT NULL, DROP PRIMARY KEY, ADD PRIMARY KEY (doctor_id, city_id);
ALTER TABLE doctor_cities ADD CONSTRAINT FK_7DC181E68BAC62AF FOREIGN KEY (city_id) REFERENCES cities (id);
CREATE INDEX IDX_7DC181E68BAC62AF ON doctor_cities (city_id);
END IF;
-- Drop the now-unused categories table
IF EXISTS (
SELECT 1 FROM information_schema.TABLES
WHERE TABLE_SCHEMA = db AND TABLE_NAME = 'categories'
) THEN
DROP TABLE categories;
END IF;
END
SQL);
$this->addSql('CALL __mig_140853()');
$this->addSql('DROP PROCEDURE __mig_140853');
}
public function down(Schema $schema): void