fix(secretary): settings menu structure, clinic timeline access, patient delete gate

Three reported secretary-access bugs.

1) Settings menu structure. Phase B flat-listed staff/discounts/sms/tags/
   appointment_settings/clinic_doctors in the secretary's main sidebar. Mirror
   the doctor/clinic layout instead: only inventory + services stay in the main
   «مدیریت» nav; the rest live under a single «تنظیمات» entry
   (→ /admin/account-settings). Made both settings navs permission-aware for
   secretaries: SETTINGS_MENU (menuForRole now takes `can`) and
   PurchaseSubscriptionSidebar filter by a per-item `perm`/`alwaysOpen` instead
   of role only, so a secretary sees exactly their permitted settings pages and
   owner-only items (subscription, secretary-management) stay hidden.

2) Clinic secretary appointment timeline. AppointmentsPage treated a
   clinic-scoped secretary as a single-doctor profile: the doctor list was
   fetched/shown only for isClinic/isAdmin, so no doctor tabs, timeline, or
   booking. Now a clinic-scoped secretary is multi-doctor: fetches the doctor
   list, shows tabs, auto-selects the first doctor. The list comes from a new
   authenticated endpoint GET /api/v1/my/clinic-doctors returning only the
   secretary's ASSIGNED doctors — /clinic/doctor-list is on the public (no-JWT)
   firewall and cannot scope by user, so it would have leaked unbookable doctors.

3) Patient record delete. The `patients.delete` toggle was dead: every record
   delete (note/medical-record/attachment/call/message) was gated as
   `patients.update`. Mapped them to `patients.delete` so the toggle is honored
   and delete is controllable separately from edit.

New SecretaryAccessChecker::assignedClinicDoctorIds. Tests: doctor-list scoping,
patients.delete separation (denied/allowed). docs/api secretary.md +
appointment.md updated. Backend 286 + frontend 25 pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
hamed
2026-07-23 18:01:32 +03:30
co-authored by Claude Opus 4.8
parent 653dd57300
commit 54c8b008bf
14 changed files with 274 additions and 122 deletions
+15 -48
View File
@@ -18,7 +18,6 @@ import {
KeyIcon,
LockClosedIcon,
PlusIcon,
ReceiptPercentIcon,
ShieldCheckIcon,
StarIcon,
TagIcon,
@@ -416,60 +415,28 @@ function buildSections(
label: "انبارداری",
});
}
if (can("tags", "view")) {
items.push({
to: "/admin/tags-settings",
icon: TagIcon,
label: "تگ‌ها",
});
}
if (can("staff", "view")) {
items.push({
to: "/admin/staff",
icon: UsersIcon,
label: "پرسنل",
});
}
if (can("discounts", "view")) {
items.push({
to: "/admin/discounts",
icon: ReceiptPercentIcon,
label: "تخفیف‌ها",
});
}
if (can("sms", "view")) {
items.push({
to: "/admin/sms-wallet",
icon: DevicePhoneMobileIcon,
label: "پیامک‌ها",
});
}
if (can("appointment_settings", "view")) {
items.push({
// مسیر بسته به محیط فعال: کلینیک vs مطب شخصی.
to:
scope === "clinic"
? "/admin/settings/appointment-settings"
: "/admin/appointment-settings",
icon: Cog6ToothIcon,
label: "تنظیمات نوبت‌دهی",
});
}
// مدیریت پزشکان کلینیک فقط در محیطِ کلینیک معنا دارد.
if (scope === "clinic" && can("clinic_doctors", "view")) {
items.push({
to: "/admin/settings/clinic-doctors",
icon: HeartIcon,
label: "پزشکان کلینیک",
});
}
// منابعِ زیرمجموعهٔ «تنظیمات» (staff/discounts/sms/tags/appointment_settings/
// clinic_doctors) در سایدبار اصلی نمی‌آیند — دقیقاً مثل پزشک/کلینیک، فقط داخل
// صفحهٔ «تنظیمات» با منویِ permission-aware نمایش داده می‌شوند.
return [
{
label: "عمومی",
items: [{ to: "/admin/dashboard", icon: ChartBarIcon, label: "داشبورد" }],
},
{ label: "مدیریت", items },
{
label: "تنظیمات",
items: [
{
// لندینگِ تنظیمات؛ حساب کاربری همیشه باز است و منویِ کناری
// بقیهٔ بخش‌های مجاز را بر اساس permission نشان می‌دهد.
to: "/admin/account-settings",
icon: Cog6ToothIcon,
label: "تنظیمات",
},
],
},
];
}