refactor(pricing): make the service the only price source

Price lists, annual tariffs and per-branch price overrides each answered
"what does this service cost?" differently, so a single date could carry
several answers and nobody could say which one was right. Price now lives
only on ServiceItem.price_rials, edited from the services page.

- drop PriceList/PriceListItem, their repositories and the seven
  /api/v1/price-list(s) endpoints; PricingController keeps only quote and
  the appointment price snapshot
- drop Tariff, TariffRepository, TariffService and the two
  /service-items/{uuid}/tariffs endpoints; creating or repricing a service
  no longer upserts a current-year tariff
- drop price_rials from ServiceBranchOverride; the entity stays for its
  duration columns, which DurationCalculator and ServiceSelectionValidator
  still read
- InvoiceService reads the item price directly
- PricingEngine collapses to a single source; breakdown.sources always
  reports service_item, keeping the response contract intact
- remove the price-lists admin page, its route and settings-menu entry, the
  tariff modal and the service detail tariffs tab; useAppointmentInvoice
  moves to its own hook file

Migration drops price_lists, price_list_items, service_tariffs and the
override price column.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
hamed
2026-08-02 18:00:48 +03:30
co-authored by Claude Opus 5
parent f06efe26c0
commit 4fe0c4f9bf
41 changed files with 208 additions and 1835 deletions
+1 -164
View File
@@ -7,12 +7,7 @@ use App\Auth\Entity\User;
use App\Doctor\Service\AddressResolver;
use App\ClinicService\Entity\ServiceItem;
use App\ClinicService\Repository\ServiceItemRepository;
use App\Pricing\Entity\PriceList;
use App\Pricing\Entity\PriceListItem;
use App\Pricing\Repository\PriceListItemRepository;
use App\Pricing\Repository\PriceListRepository;
use App\Pricing\Repository\PriceSnapshotRepository;
use App\Patient\Repository\PatientRecordRepository;
use App\Pricing\Service\PricingEngine;
use App\Shared\Constant\ErrorCodes;
use App\Shared\Controller\BaseController;
@@ -31,160 +26,14 @@ use Symfony\Component\Security\Http\Attribute\IsGranted;
class PricingController extends BaseController
{
public function __construct(
private readonly PriceListRepository $lists,
private readonly PriceListItemRepository $listItems,
private readonly PriceSnapshotRepository $snapshots,
private readonly ServiceItemRepository $items,
private readonly PricingEngine $engine,
private readonly AddressResolver $branches,
private readonly AddressResolver $branches,
private readonly TenantOwnershipChecker $ownership,
private readonly EntityManagerInterface $em,
) {}
#[Route('/api/v1/price-lists', name: 'price_list_index', methods: ['GET'])]
public function index(#[CurrentUser] User $user): JsonResponse
{
[$entityType, $entityId] = $this->branches->pair($user);
return $this->success(array_map(
static fn (PriceList $l): array => $l->toArray(),
$this->lists->findForPair($entityType, $entityId),
));
}
#[Route('/api/v1/price-lists', name: 'price_list_create', methods: ['POST'])]
public function create(#[CurrentUser] User $user, Request $request): JsonResponse
{
$data = json_decode($request->getContent(), true);
if (!is_array($data) || !is_string($data['name'] ?? null) || trim($data['name']) === '') {
return $this->error(ErrorCodes::ERR_VALIDATION_002, 'نام لیست قیمت الزامی است', 422, 'name');
}
if (!is_numeric($data['starts_at'] ?? null) || !is_numeric($data['ends_at'] ?? null)) {
return $this->error(ErrorCodes::ERR_VALIDATION_002, 'بازهٔ تاریخ الزامی است', 422, 'starts_at');
}
[$entityType, $entityId] = $this->branches->pair($user);
try {
$list = new PriceList($entityType, $entityId, trim($data['name']), (int) $data['starts_at'], (int) $data['ends_at']);
} catch (\InvalidArgumentException) {
return $this->error(ErrorCodes::ERR_VALIDATION_001, 'پایان بازه باید بعد از شروع آن باشد', 422, 'ends_at');
}
if (is_string($data['address_uuid'] ?? null)) {
$list->setAddress($this->branches->resolve($user, $data['address_uuid']));
}
$this->em->persist($list);
$this->em->flush();
return $this->success($list->toArray(), 201);
}
#[Route('/api/v1/price-list/{uuid}', name: 'price_list_show', methods: ['GET'])]
public function show(#[CurrentUser] User $user, string $uuid): JsonResponse
{
return $this->success($this->requireList($user, $uuid)->toArray());
}
#[Route('/api/v1/price-list/{uuid}', name: 'price_list_update', methods: ['PATCH'])]
public function update(#[CurrentUser] User $user, string $uuid, Request $request): JsonResponse
{
$data = json_decode($request->getContent(), true);
$list = $this->requireList($user, $uuid);
if (!is_array($data)) {
return $this->error(ErrorCodes::ERR_VALIDATION_001, 'بدنهٔ درخواست نامعتبر است', 422);
}
if (is_string($data['name'] ?? null) && trim($data['name']) !== '') {
$list->setName(trim($data['name']));
}
if (array_key_exists('active', $data)) {
$list->setActive((bool) $data['active']);
}
$this->em->flush();
return $this->success($list->toArray());
}
#[Route('/api/v1/price-list/{uuid}', name: 'price_list_delete', methods: ['DELETE'])]
public function delete(#[CurrentUser] User $user, string $uuid): JsonResponse
{
$this->em->remove($this->requireList($user, $uuid));
$this->em->flush();
return $this->success(null);
}
#[Route('/api/v1/price-list/{uuid}/items', name: 'price_list_items_replace', methods: ['PUT'])]
public function replaceItems(#[CurrentUser] User $user, string $uuid, Request $request): JsonResponse
{
$data = json_decode($request->getContent(), true);
if (!is_array($data) || !is_array($data['items'] ?? null)) {
return $this->error(ErrorCodes::ERR_VALIDATION_002, 'فیلد items الزامی است', 422, 'items');
}
$list = $this->requireList($user, $uuid);
$resolved = [];
foreach ($data['items'] as $row) {
if (!is_array($row) || !is_string($row['service_uuid'] ?? null) || !is_numeric($row['price_rials'] ?? null)) {
return $this->error(ErrorCodes::ERR_VALIDATION_002, 'service_uuid و price_rials الزامی‌اند', 422, 'items');
}
if ((int) $row['price_rials'] < 0) {
return $this->error(ErrorCodes::ERR_VALIDATION_001, 'قیمت نمی‌تواند منفی باشد', 422, 'price_rials');
}
$resolved[] = [$this->requireItem($user, $row['service_uuid']), (int) $row['price_rials']];
}
$this->listItems->deleteForList($list);
$list->getItems()->clear();
foreach ($resolved as [$service, $price]) {
$item = new PriceListItem($list, $service, $price);
$this->em->persist($item);
$list->getItems()->add($item);
}
$list->touch();
$this->em->flush();
return $this->success($list->toArray());
}
/**
* فعال‌سازی با بررسی تداخل: دو لیستِ فعالِ هم‌پوشان یعنی یک تاریخ دو قیمت دارد و
* هیچ‌کس نمی‌تواند بگوید کدام درست است.
*/
#[Route('/api/v1/price-list/{uuid}/activate', name: 'price_list_activate', methods: ['POST'])]
public function activate(#[CurrentUser] User $user, string $uuid): JsonResponse
{
$list = $this->requireList($user, $uuid);
$conflicts = $this->lists->findOverlapping($list);
if ($conflicts !== []) {
return $this->error(
ErrorCodes::ERR_VALIDATION_001,
sprintf('بازهٔ این لیست با «%s» هم‌پوشانی دارد', $conflicts[0]->getName()),
422,
'starts_at',
);
}
$list->setActive(true);
$this->em->flush();
return $this->success($list->toArray());
}
#[Route('/api/v1/pricing/quote', name: 'pricing_quote', methods: ['POST'])]
public function quote(#[CurrentUser] User $user, Request $request): JsonResponse
{
@@ -236,18 +85,6 @@ class PricingController extends BaseController
return $this->success($snapshot->toArray());
}
private function requireList(User $user, string $uuid): PriceList
{
$list = $this->lists->findByUuid($uuid);
[$entityType, $entityId] = $this->branches->pair($user);
if ($list === null || !$this->ownership->belongsToPair($entityType, $entityId, $list)) {
throw new AppException(ErrorCodes::ERR_NOT_FOUND_001, 'لیست قیمت یافت نشد', 404);
}
return $list;
}
private function requireItem(User $user, string $uuid): ServiceItem
{
$item = $this->items->findByUuid($uuid);
-125
View File
@@ -1,125 +0,0 @@
<?php
namespace App\Pricing\Entity;
use App\Doctor\Entity\DoctorAddress;
use App\Pricing\Repository\PriceListRepository;
use App\Shared\Tenant\TenantOwnedTrait;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Uid\Uuid;
/**
* لیست قیمت با **بازهٔ تاریخ** — بند ۱۲ مستند.
*
* `Tariff` موجود فقط «سال» دارد، پس تغییر تعرفه از اول مهر قابل بیان نیست. این جدول
* بازهٔ دقیق می‌گیرد و `Tariff` به‌عنوان لایهٔ پشتیبان سرِ جایش می‌ماند.
*
* `address` تهی‌پذیر است: `null` یعنی «همهٔ شعبه‌های این محیط». قیمت اختصاصی یک شعبه
* از {@see \App\ClinicService\Entity\ServiceBranchOverride} می‌آید که بر این مقدم است.
*/
#[ORM\Entity(repositoryClass: PriceListRepository::class)]
#[ORM\Table(name: 'price_lists')]
#[ORM\Index(columns: ['entity_type', 'entity_id', 'active'], name: 'idx_price_list_tenant')]
#[ORM\Index(columns: ['starts_at', 'ends_at'], name: 'idx_price_list_range')]
class PriceList
{
use TenantOwnedTrait;
#[ORM\Id]
#[ORM\GeneratedValue]
#[ORM\Column(type: 'integer')]
private ?int $id = null;
#[ORM\Column(type: 'string', length: 36, unique: true)]
private string $uuid;
#[ORM\ManyToOne(targetEntity: DoctorAddress::class)]
#[ORM\JoinColumn(name: 'address_id', referencedColumnName: 'id', nullable: true, onDelete: 'CASCADE')]
private ?DoctorAddress $address = null;
#[ORM\Column(type: 'string', length: 150)]
private string $name;
#[ORM\Column(name: 'starts_at', type: 'integer')]
private int $startsAt;
#[ORM\Column(name: 'ends_at', type: 'integer')]
private int $endsAt;
/** تا فعال نشده هیچ اثری ندارد؛ ساختنِ پیش‌نویس نباید قیمت امروز را عوض کند. */
#[ORM\Column(type: 'boolean', options: ['default' => false])]
private bool $active = false;
#[ORM\Column(name: 'created_at', type: 'integer')]
private int $createdAt;
#[ORM\Column(name: 'updated_at', type: 'integer')]
private int $updatedAt;
/** @var Collection<int, PriceListItem> */
#[ORM\OneToMany(targetEntity: PriceListItem::class, mappedBy: 'priceList', cascade: ['persist', 'remove'], orphanRemoval: true)]
private Collection $items;
public function __construct(string $entityType, int $entityId, string $name, int $startsAt, int $endsAt)
{
if ($endsAt <= $startsAt) {
throw new \InvalidArgumentException('Price list end must be after its start.');
}
$this->uuid = Uuid::v4()->toRfc4122();
$this->name = $name;
$this->startsAt = $startsAt;
$this->endsAt = $endsAt;
$this->createdAt = time();
$this->updatedAt = time();
$this->items = new ArrayCollection();
$this->assignTenantPair($entityType, $entityId);
}
public function getId(): ?int { return $this->id; }
public function getUuid(): string { return $this->uuid; }
public function getAddress(): ?DoctorAddress { return $this->address; }
public function getName(): string { return $this->name; }
public function getStartsAt(): int { return $this->startsAt; }
public function getEndsAt(): int { return $this->endsAt; }
public function isActive(): bool { return $this->active; }
/** @return Collection<int, PriceListItem> */
public function getItems(): Collection { return $this->items; }
public function setAddress(?DoctorAddress $v): self { $this->address = $v; $this->touch(); return $this; }
public function setName(string $v): self { $this->name = $v; $this->touch(); return $this; }
public function setActive(bool $v): self { $this->active = $v; $this->touch(); return $this; }
public function covers(int $at): bool
{
return $this->active && $at >= $this->startsAt && $at < $this->endsAt;
}
public function overlaps(int $startsAt, int $endsAt): bool
{
return $startsAt < $this->endsAt && $endsAt > $this->startsAt;
}
public function touch(): void { $this->updatedAt = time(); }
public function toArray(): array
{
return [
'uuid' => $this->uuid,
'name' => $this->name,
'address_uuid' => $this->address?->getUuid(),
'address_name' => $this->address?->getName(),
'starts_at' => $this->startsAt,
'ends_at' => $this->endsAt,
'active' => $this->active,
'items' => array_map(
static fn (PriceListItem $i): array => $i->toArray(),
$this->items->toArray(),
),
];
}
}
-58
View File
@@ -1,58 +0,0 @@
<?php
namespace App\Pricing\Entity;
use App\ClinicService\Entity\ServiceItem;
use App\Pricing\Repository\PriceListItemRepository;
use Doctrine\ORM\Mapping as ORM;
/**
* قیمت یک سرویس در یک لیست قیمت. فرزند aggregate با ریشهٔ {@see PriceList} که خودش
* جفت محیط دارد؛ uuid از request نمی‌گیرد.
*/
#[ORM\Entity(repositoryClass: PriceListItemRepository::class)]
#[ORM\Table(name: 'price_list_items')]
#[ORM\UniqueConstraint(name: 'uniq_price_list_service', columns: ['price_list_id', 'service_item_id'])]
class PriceListItem
{
#[ORM\Id]
#[ORM\GeneratedValue]
#[ORM\Column(type: 'integer')]
private ?int $id = null;
#[ORM\ManyToOne(targetEntity: PriceList::class, inversedBy: 'items')]
#[ORM\JoinColumn(name: 'price_list_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
private PriceList $priceList;
#[ORM\ManyToOne(targetEntity: ServiceItem::class)]
#[ORM\JoinColumn(name: 'service_item_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
private ServiceItem $serviceItem;
#[ORM\Column(name: 'price_rials', type: 'bigint')]
private int $priceRials;
public function __construct(PriceList $priceList, ServiceItem $serviceItem, int $priceRials)
{
if ($priceRials < 0) {
throw new \InvalidArgumentException('Price cannot be negative.');
}
$this->priceList = $priceList;
$this->serviceItem = $serviceItem;
$this->priceRials = $priceRials;
}
public function getId(): ?int { return $this->id; }
public function getPriceList(): PriceList { return $this->priceList; }
public function getServiceItem(): ServiceItem { return $this->serviceItem; }
public function getPriceRials(): int { return (int) $this->priceRials; }
public function toArray(): array
{
return [
'service_uuid' => $this->serviceItem->getUuid(),
'service_name' => $this->serviceItem->getName(),
'price_rials' => $this->getPriceRials(),
];
}
}
@@ -1,59 +0,0 @@
<?php
namespace App\Pricing\Repository;
use App\ClinicService\Entity\ServiceItem;
use App\Pricing\Entity\PriceList;
use App\Pricing\Entity\PriceListItem;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;
/**
* @extends ServiceEntityRepository<PriceListItem>
*/
class PriceListItemRepository extends ServiceEntityRepository
{
public function __construct(ManagerRegistry $registry)
{
parent::__construct($registry, PriceListItem::class);
}
public function deleteForList(PriceList $list): int
{
return (int) $this->createQueryBuilder('i')
->delete()
->where('i.priceList = :list')
->setParameter('list', $list)
->getQuery()
->execute();
}
/**
* قیمت چند سرویس در یک لیست — یک کوئری، نه یکی per سرویس.
*
* @param ServiceItem[] $services
* @return array<int, int> شناسهٔ سرویس => قیمت
*/
public function priceMap(PriceList $list, array $services): array
{
if ($services === []) {
return [];
}
$rows = $this->createQueryBuilder('i')
->select('IDENTITY(i.serviceItem) AS service_id, i.priceRials AS price')
->where('i.priceList = :list')
->andWhere('i.serviceItem IN (:services)')
->setParameter('list', $list)
->setParameter('services', $services)
->getQuery()
->getArrayResult();
$map = [];
foreach ($rows as $row) {
$map[(int) $row['service_id']] = (int) $row['price'];
}
return $map;
}
}
@@ -1,102 +0,0 @@
<?php
namespace App\Pricing\Repository;
use App\Doctor\Entity\DoctorAddress;
use App\Pricing\Entity\PriceList;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;
/**
* @extends ServiceEntityRepository<PriceList>
*/
class PriceListRepository extends ServiceEntityRepository
{
public function __construct(ManagerRegistry $registry)
{
parent::__construct($registry, PriceList::class);
}
public function findByUuid(string $uuid): ?PriceList
{
return $this->findOneBy(['uuid' => $uuid]);
}
/** @return PriceList[] */
public function findForPair(string $entityType, int $entityId): array
{
return $this->createQueryBuilder('p')
->where('p.entityType = :type')
->andWhere('p.entityId = :id')
->setParameter('type', $entityType)
->setParameter('id', $entityId)
->orderBy('p.startsAt', 'DESC')
->getQuery()
->getResult();
}
/**
* لیست قیمتِ حاکم بر یک لحظه.
*
* لیستِ مخصوصِ همان شعبه بر لیست عمومیِ محیط مقدم است — وگرنه تعریف استثنا برای
* یک شعبه هیچ اثری نداشت.
*/
public function findCovering(string $entityType, int $entityId, ?DoctorAddress $address, int $at): ?PriceList
{
$rows = $this->createQueryBuilder('p')
->where('p.entityType = :type')
->andWhere('p.entityId = :id')
->andWhere('p.active = true')
->andWhere('p.startsAt <= :at')
->andWhere('p.endsAt > :at')
->setParameter('type', $entityType)
->setParameter('id', $entityId)
->setParameter('at', $at)
->getQuery()
->getResult();
$general = null;
foreach ($rows as $list) {
if ($address !== null && $list->getAddress()?->getId() === $address->getId()) {
return $list;
}
if ($list->getAddress() === null) {
$general = $list;
}
}
return $general;
}
/**
* لیست‌های فعالِ هم‌پوشان با یک بازه — برای جلوگیری از دو قیمتِ هم‌زمان.
*
* @return PriceList[]
*/
public function findOverlapping(PriceList $candidate): array
{
$qb = $this->createQueryBuilder('p')
->where('p.entityType = :type')
->andWhere('p.entityId = :id')
->andWhere('p.active = true')
->andWhere('p.startsAt < :ends')
->andWhere('p.endsAt > :starts')
->setParameter('type', $candidate->getEntityType())
->setParameter('id', $candidate->getEntityId())
->setParameter('starts', $candidate->getStartsAt())
->setParameter('ends', $candidate->getEndsAt());
if ($candidate->getId() !== null) {
$qb->andWhere('p.id != :self')->setParameter('self', $candidate->getId());
}
// فقط لیست‌هایی که دامنهٔ یکسانی دارند با هم تداخل دارند: لیست عمومی و لیست
// یک شعبه عمداً کنار هم زندگی می‌کنند و اولویت دارند، نه تداخل.
return array_values(array_filter(
$qb->getQuery()->getResult(),
static fn (PriceList $other): bool => $other->getAddress()?->getId() === $candidate->getAddress()?->getId(),
));
}
}
+8 -63
View File
@@ -3,14 +3,8 @@
namespace App\Pricing\Service;
use App\ClinicService\Entity\ServiceItem;
use App\ClinicService\Repository\ServiceBranchOverrideRepository;
use App\ClinicService\Repository\TariffRepository;
use App\Doctor\Entity\DoctorAddress;
use App\Patient\Entity\PatientRecord;
use App\Pricing\Repository\PriceListItemRepository;
use App\Pricing\Repository\PriceListRepository;
use App\Pricing\ValueObject\PriceQuote;
use App\Representation\Service\JalaliDateService;
/**
* زنجیرهٔ قیمت‌گذاری بند ۱۲ مستند.
@@ -19,27 +13,14 @@ use App\Representation\Service\JalaliDateService;
* قیمت پایه → + آیتم‌ها → − تخفیف → − بیمهٔ پایه → − تکمیلی → + مالیات → بیعانه
* ```
*
* ## زنجیرهٔ منبع قیمت
* ## منبع قیمت
*
* برای هر سرویس، اولین چیزی که پیدا شود برنده است:
*
* ۱. override شعبه ({@see \App\ClinicService\Entity\ServiceBranchOverride}) — تسک ۰۴
* ۲. لیست قیمتِ حاکم بر آن تاریخ — همین تسک
* ۳. `Tariff` سال — لایهٔ موجود
* ۴. `ServiceItem::priceRials` — همیشه هست
*
* مرحلهٔ چهارم ضامن است که **هرگز صفر یا خطا** برنگردد: تاریخی که هیچ لیستی نمی‌پوشاند
* باید قیمت بدهد، نه استثنا.
* تنها منبع قیمت، `ServiceItem::priceRials` است — قیمت روی خودِ سرویس مدیریت می‌شود.
* لایه‌های پیشینِ «لیست قیمت»، «تعرفهٔ سالانه» و «قیمت اختصاصی شعبه» حذف شده‌اند تا یک
* تاریخ هرگز دو قیمت نداشته باشد.
*/
final class PricingEngine
{
public function __construct(
private readonly PriceListRepository $priceLists,
private readonly PriceListItemRepository $priceListItems,
private readonly ServiceBranchOverrideRepository $overrides,
private readonly TariffRepository $tariffs,
private readonly JalaliDateService $jalali,
) {}
/**
* @param ServiceItem[] $items آیتم‌های انتخاب‌شده (بدون خودِ سرویس)
@@ -57,18 +38,13 @@ final class PricingEngine
int $at,
array $policy = [],
): PriceQuote {
$entityType = $address->tenantEntityType();
$entityId = $address->tenantEntityId();
$list = $this->priceLists->findCovering($entityType, $entityId, $address, $at);
$sources = [];
$base = $this->priceFor($service, $address, $list, $at, $sources);
$base = $this->priceFor($service, $sources);
$itemsTotal = 0;
foreach ($items as $item) {
$itemsTotal += $this->priceFor($item, $address, $list, $at, $sources);
$itemsTotal += $this->priceFor($item, $sources);
}
$subtotal = $base + $itemsTotal;
@@ -121,39 +97,8 @@ final class PricingEngine
/**
* @param array<string, string> $sources
*/
private function priceFor(
ServiceItem $service,
DoctorAddress $address,
?\App\Pricing\Entity\PriceList $list,
int $at,
array &$sources,
): int {
$override = $this->overrides->mapForAddress([(int) $service->getId()], $address)[(int) $service->getId()] ?? null;
if ($override?->getPriceRials() !== null) {
$sources[$service->getUuid()] = 'branch_override';
return $override->getPriceRials();
}
if ($list !== null) {
$price = $this->priceListItems->priceMap($list, [$service])[(int) $service->getId()] ?? null;
if ($price !== null) {
$sources[$service->getUuid()] = 'price_list';
return $price;
}
}
$tariff = $this->tariffs->findForServiceYear((int) $service->getId(), $this->jalali->jalaliYear($at));
if ($tariff !== null) {
$sources[$service->getUuid()] = 'tariff';
return (int) $tariff->getPriceRials();
}
private function priceFor(ServiceItem $service, array &$sources): int
{
$sources[$service->getUuid()] = 'service_item';
return $service->getPriceRials();